Differential D25018 Diff 56 src/applications/legalpad/conduit/LegalpadDocumentSearchConduitAPIMethod.php

Changeset View

Standalone View

src/applications/legalpad/conduit/LegalpadDocumentSearchConduitAPIMethod.php

This file was added.

				<?php

				final class LegalpadDocumentSearchConduitAPIMethod
				extends PhabricatorSearchEngineAPIMethod {
				speckUnsubmitted Done Inline Actions I believe there's a `getApplication()` function that should be overridden to associate these APIs with the Legalpad application. Doing so will cause the APIs to require access to the Legalpad application by the accessor/viewer. Additionally is there a way to provide more information about search constraints for these apis, a la `getMethodDocumentation()`? speck: I believe there's a `getApplication()` function that should be overridden to associate these…
				roguelazerAuthorUnsubmitted Done Inline Actions `getApplication` is implemented by `PhabricatorSearchEngineAPIMethod`: rP src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php:29-33 `getMethodDocumentation` and `getMethodDescription` are also implemented automatically in `PhabricatorSearchEngineAPIMethod`. It doesn't look to me like they're overridden by any of the other subclasses of `PhabricatorSearchEngineAPIMethod`? roguelazer: `getApplication` is implemented by `PhabricatorSearchEngineAPIMethod`: {src rP…
				speckUnsubmitted Not Done Inline Actions Thanks for checking. Does the conduit page for these new apis identify the search criteria (constraints?) that can be used? If so then this is probably all connected via some reflection. speck: Thanks for checking. Does the conduit page for these new apis identify the search criteria…
				roguelazerAuthorUnsubmitted Done Inline Actions It does: roguelazer: It does: {F14208}
				speckUnsubmitted Not Done Inline Actions Ah thanks! speck: Ah thanks!

				public function getAPIMethodName() {
				return 'legalpad.document.search';
				}

				public function newSearchEngine() {
				return new LegalpadDocumentSearchEngine();
				}

				public function getMethodSummary() {
				return pht('Read information about legalpad documents.');
				}

				}