Differential D25425 Diff 1448 src/applications/config/check/PhabricatorAuthSetupCheck.php

Changeset View

Standalone View

src/applications/config/check/PhabricatorAuthSetupCheck.php

Show First 20 Lines • Show All 66 Lines • ▼ Show 20 Lines	if (!$is_locked && !$did_warn) {
->setShortName(pht('Auth Config Unlocked'))		->setShortName(pht('Auth Config Unlocked'))
->setName(pht('Authenticaton Configuration Unlocked'))		->setName(pht('Authenticaton Configuration Unlocked'))
->setSummary(		->setSummary(
pht(		pht(
'Authentication configuration is currently unlocked. Once you '.		'Authentication configuration is currently unlocked. Once you '.
'finish configuring authentication, you should lock it.'))		'finish configuring authentication, you should lock it.'))
->setMessage($message)		->setMessage($message)
->addRelatedPhabricatorConfig('auth.lock-config')		->addRelatedPhabricatorConfig('auth.lock-config')
->addCommand(		->addCommand(hsprintf('<tt>$</tt> ./bin/auth lock'));
		valerio.bozzolanUnsubmitted Not Done Inline Actions So, maybe just this, in order to have the minimal fix for the brand issue: ->addCommand( hsprintf( '<tt>%s $</tt> ./bin/auth lock', PlatformSymbols::getPlatformServerPath())); Then we can do something else to have the server path non-selectable valerio.bozzolan: So, maybe just this, in order to have the minimal fix for the brand issue: ```lang=php…
		valerio.bozzolanUnsubmitted Not Done Inline Actions Then we can do something else to have the server path non-selectable With this phrase I mean, later, with another patch, we can surely try to improve the `<tt>` tag to be non-selectable. But maybe not now. It's still useful to see where this command should be executed (so, from Arcanist, or from Phorge, etc.) so the prefix is probably still useful. valerio.bozzolan: > Then we can do something else to have the server path non-selectable With this phrase I mean…
		waldyriousAuthorUnsubmitted Not Done Inline Actions So, maybe just this, in order to have the minimal fix for the brand issue: I would normally agree, but this was (AFAICT) the only case of a path being shown before the prompt symbol in these check messages. So I think this change (removing "phabricator" altogether rather than just replacing it with `getPlatformServerPath()`) is justified because it aligns this code with all the other ones. That's not to say I don't see the value of having the path here — but like the non-selectability bit, I think adding the path should be done in a separate patch and affecting all similar messages consistently. waldyrious: > So, maybe just this, in order to have the minimal fix for the brand issue: I would normally…
hsprintf(
'<tt>phabricator/ $</tt> ./bin/auth lock'));
}		}
}		}
}		}