Changeset View
Changeset View
Standalone View
Standalone View
webroot/rsrc/externals/javelin/lib/Workflow.js
Context not available. | |||||
JX.$E('Response to workflow request went unhandled.'); | JX.$E('Response to workflow request went unhandled.'); | ||||
} | } | ||||
} | } | ||||
bekay: When `this._root` is undefined, this change will throw errors. `scry` requires a root and will… | |||||
Not Done Inline ActionsThe follow-up change is here: valerio.bozzolan: The follow-up change is here:
{D25076} | |||||
var form = JX.DOM.scry(this._root, 'form', 'jx-dialog'); | |||||
if (form.length) { | |||||
JX.DOM.listen(form[0], 'keydown', null, function(e) { | |||||
if (e.getSpecialKey()) { | |||||
return; | |||||
} | |||||
JX.Stratcom.addSigil(form[0], 'dialog-keydown'); | |||||
}); | |||||
} | |||||
}, | }, | ||||
_push : function() { | _push : function() { | ||||
if (!this._pushed) { | if (!this._pushed) { | ||||
Context not available. | |||||
// No 'Cancel' button. | // No 'Cancel' button. | ||||
return; | return; | ||||
} | } | ||||
var form = JX.DOM.scry(active._root, 'form', 'jx-dialog'); | |||||
if ( | |||||
form.length && | |||||
JX.Stratcom.hasSigil(form[0], 'dialog-keydown') && | |||||
!confirm('Form data may have changed. Are you sure you want to close this dialog?') | |||||
EkubischtaUnsubmitted Not Done Inline ActionsMy only concern with this is the text bypasses the translation layer (pht) Ekubischta: My only concern with this is the text bypasses the translation layer (`pht`) | |||||
) { | |||||
return; | |||||
} | |||||
JX.Workflow._pop(); | JX.Workflow._pop(); | ||||
e.prevent(); | e.prevent(); | ||||
Context not available. |
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
When this._root is undefined, this change will throw errors. scry requires a root and will fail loudly. This part should go somewhere into the condition clause starting on line 330 - only when the response is a dialog you want to listen to form changes.