Differential D25051 Diff 1391 src/applications/files/storage/PhabricatorFile.php

Changeset View

Standalone View

src/applications/files/storage/PhabricatorFile.php

	Show First 20 Lines • Show All 1,699 Lines • ▼ Show 20 Lines

	/* -( PhabricatorDestructibleInterface )----------------------------------- */			/* -( PhabricatorDestructibleInterface )----------------------------------- */


	public function destroyObjectPermanently(			public function destroyObjectPermanently(
	PhabricatorDestructionEngine $engine) {			PhabricatorDestructionEngine $engine) {

	$this->openTransaction();			$this->openTransaction();

				$attachments = id(new PhabricatorFileAttachment())->loadAllWhere(
				'filePHID = %s',
				$this->getPHID());
				valerio.bozzolanUnsubmitted Done Inline Actions ✅ Note that I like that you have built this query in the raw way, instead of using `PhabricatorFileAttachmentQuery()` since in the raw way it does not try to pull the objects, and, it will not discard results if objects are already deleted for some reasons, and, there is no extra overhead for the omnipotent user thing. valerio.bozzolan: ✅ Note that I like that you have built this query in the raw way, instead of using…
				foreach ($attachments as $attachment) {
				$attachment->delete();
				aviveyUnsubmitted Not Done Inline Actions I don't like using `mpull` for the side-effect of the method invoked. avivey: I don't like using `mpull` for the side-effect of the method invoked.
				valerio.bozzolanUnsubmitted Not Done Inline Actions I agree, also because it returns an array of `[null, null, null, null]` which is not useful to read. A simple `foreach()` may be better valerio.bozzolan: I agree, also because it returns an array of `[null, null, null, null]` which is not useful to…
				}

	$this->delete();			$this->delete();
	$this->saveTransaction();			$this->saveTransaction();
	}			}


	/* -( PhabricatorConduitResultInterface )---------------------------------- */			/* -( PhabricatorConduitResultInterface )---------------------------------- */


	▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines