Differential D25358 Diff 1161 src/workflow/ArcanistExportWorkflow.php

Changeset View

Standalone View

src/workflow/ArcanistExportWorkflow.php

Show First 20 Lines • Show All 197 Lines • ▼ Show 20 Lines	switch ($source) {
'phids' => array($this->getUserPHID()),		'phids' => array($this->getUserPHID()),
));		));
$author_dict = reset($authors);		$author_dict = reset($authors);

list($email) = $repository_api->execxLocal('config user.email');		list($email) = $repository_api->execxLocal('config user.email');

$author = sprintf('%s <%s>',		$author = sprintf('%s <%s>',
$author_dict['realName'],		$author_dict['realName'],
$email);		trim($email));
		aviveyAuthorUnsubmitted Done Inline Actions This is not related, but I was already here. `git config ...` adds a newline to the output. avivey: This is not related, but I was already here. `git config ...` adds a newline to the output.
		valerio.bozzolanUnsubmitted Not Done Inline Actions If the need is to remove a newline, note that trim() removes spaces valerio.bozzolan: If the need is to remove a newline, note that trim() removes spaces
		aviveyAuthorUnsubmitted Done Inline Actions close enough - email shouldn't have any whitespace in it, afaik. avivey: close enough - email shouldn't have any whitespace in it, afaik.
		valerio.bozzolanUnsubmitted Done Inline Actions Oh sorry - I'm wrong! trim() as default removes that since always http://web.archive.org/web/20010215013717/https://www.php.net/manual/en/function.trim.php And now I have to fix some other trims in other projects... valerio.bozzolan: Oh sorry - I'm wrong! trim() as default removes that since always http://web.archive.
} else if ($repository_api instanceof ArcanistMercurialAPI) {		} else if ($repository_api instanceof ArcanistMercurialAPI) {
$this->parseBaseCommitArgument($this->getArgument('paths'));		$this->parseBaseCommitArgument($this->getArgument('paths'));
$diff = $repository_api->getFullMercurialDiff();		$diff = $repository_api->getFullMercurialDiff();
$changes = $parser->parseDiff($diff);		$changes = $parser->parseDiff($diff);
$authors = $this->getConduit()->callMethodSynchronous(		$authors = $this->getConduit()->callMethodSynchronous(
'user.query',		'user.query',
array(		array(
'phids' => array($this->getUserPHID()),		'phids' => array($this->getUserPHID()),
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines