Differential D25117 Diff 1140 src/utils/__tests__/PhutilUtilsTestCase.php

Changeset View

Standalone View

foreach ($map as $name => $item) {

$this->assertEqual($expect, $actual, pht('Partition of "%s"', $name));

}

public function testEmptyStringMethods() {

$uri = new PhutilURI('http://example.org/');

// Each test is defined in this way:

// 0: subject $value

// 1: expected result from phutil_nonempty_string($value)

// 2: expected result from phutil_nonempty_stringlike($value)

// 3: expected result from phutil_nonempty_scalar($value)

// 4: human test name

$map = array(

array(null, false, false, false, 'literal null'),

array('', false, false, false, 'empty string'),

array('x', true, true, true, 'nonempty string'),

array(false, null, null, null, 'bool'),

array(false, null, null, false, 'false bool'),

array(true, null, null, true, 'true bool'),

valerio.bozzolanAuthorUnsubmitted

Done

This is a nightmare to read but it just reflects the above change to require not an exception. So:

Subject	test nonempty string	test nonempty string like	test nonempty scalar	Human test name
false	null	null	~~null~~ false	~~bool~~ "false bool"
true	null	null	true	"true bool"

Where it's NULL it means: return an exception.

valerio.bozzolan: This is a nightmare to read but it just reflects the above change to require not an exception.

array(1, null, null, true, 'integer'),

array($uri, null, true, true, 'uri object'),

array(2.5, null, null, true, 'float'),

array(array(), null, null, null, 'array'),

array((object)array(), null, null, null, 'object'),

);

foreach ($map as $test_case) {