Differential D25268 Diff 908 src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

Changeset View

Standalone View

Show First 20 Lines • Show All 246 Lines • ▼ Show 20 Lines	$show_diff = phutil_tag(
array(),		array(),
pht('Show Diff')),		pht('Show Diff')),
));		));

$content = phabricator_form(		$content = phabricator_form(
$this->getUser(),		$this->getUser(),
array(		array(
'action' => '/D'.$revision_id.'#toc',		'action' => '/D'.$revision_id.'#toc',
		'method' => 'GET',
		valerio.bozzolanUnsubmitted Not Done Inline Actions Can this be clarified? valerio.bozzolan: Can this be clarified?
		mturdusAuthorUnsubmitted Done Inline Actions The `phabricator_form` method contains the following lines: $http_method = idx($attributes, 'method'); $is_post = (strcasecmp($http_method, 'POST') === 0); if the `method` argument is missing, $http_method becomes null. The strcasecmp statement will crash in PHP 8.2 mturdus: The `phabricator_form` method contains the following lines: ``` $http_method = idx…
		speckUnsubmitted Not Done Inline Actions For other context, this is the only location using phabricator_form but doesn’t specify which http method to use. speck: For other context, this is the only location using phabricator_form but doesn’t specify which…
),		),
array(		array(
$table,		$table,
$show_diff,		$show_diff,
));		));

return $content;		return $content;
}		}
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines