Page MenuHomePhorge
Differential D25241 Diff 873 src/applications/diffusion/controller/DiffusionBranchTableController.php

Changeset View

Standalone View

View Options

src/applications/diffusion/controller/DiffusionBranchTableController.php

Show All 20 Lines public function handleRequest(AphrontRequest $request) {
$params = array( $params = array(
'offset' => $pager->getOffset(), 'offset' => $pager->getOffset(),
'limit' => $pager->getPageSize() + 1, 'limit' => $pager->getPageSize() + 1,
'branch' => null, 'branch' => null,
); );
$contains = $drequest->getSymbolicCommit(); $contains = $drequest->getSymbolicCommit();
if (strlen($contains)) { if (phutil_nonempty_string($contains)) {
valerio.bozzolanUnsubmitted
Done
Inline Actions

✅ The variable must be null or a string

/**
 * Get the symbolic commit associated with this request.
 *
 * A symbolic commit may be a commit hash, an abbreviated commit hash, a
 * branch name, a tag name, or an expression like "HEAD^^^". The symbolic
 * commit may also be absent.
 *
 * This method always returns the symbol present in the original request,
 * in unmodified form.
 *
 * See also @{method:getStableCommit}.
 *
 * @return string|null  Symbolic commit, if one was present in the request.
 */
public function getSymbolicCommit() {
  return $this->symbolicCommit;
}
valerio.bozzolan: ✅ The variable must be null or a string ```lang=php /** * Get the symbolic commit…
$params['contains'] = $contains; $params['contains'] = $contains;
} }
$branches = $this->callConduitWithDiffusionRequest( $branches = $this->callConduitWithDiffusionRequest(
'diffusion.branchquery', 'diffusion.branchquery',
$params); $params);
$branches = $pager->sliceResults($branches); $branches = $pager->sliceResults($branches);
▲ Show 20 Lines • Show All 103 Lines • Show Last 20 Lines
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0