Differential D25239 Diff 795 src/infrastructure/customfield/field/PhabricatorCustomField.php

Changeset View

Standalone View

Show First 20 Lines • Show All 883 Lines • ▼ Show 20 Lines	public function getNewValueForApplicationTransactions() {
return $this->getValueForStorage();		return $this->getValueForStorage();
}		}


/**		/**
* @task appxaction		* @task appxaction
*/		*/
public function setValueFromApplicationTransactions($value) {		public function setValueFromApplicationTransactions($value) {
if ($this->proxy) {		if ($this->proxy) {
return $this->proxy->setValueFromApplicationTransactions($value);		return $this->proxy->setValueFromApplicationTransactions($value);
}		} else if ($value) {
return $this->setValueFromStorage($value);		return $this->setValueFromStorage($value);
		} else {
		return $value;
		}
		speckUnsubmitted Not Done Inline Actions I think this would be a large breaking change - I think null is a valid value to be set here. The issue is likely further up the stack. speck: I think this would be a large breaking change - I think null is a valid value to be set here.
}		}


/**		/**
* @task appxaction		* @task appxaction
*/		*/
public function getNewValueFromApplicationTransactions(		public function getNewValueFromApplicationTransactions(
PhabricatorApplicationTransaction $xaction) {		PhabricatorApplicationTransaction $xaction) {
▲ Show 20 Lines • Show All 810 Lines • Show Last 20 Lines