Differential D25179 Diff 765 src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Changeset View

Standalone View

Show First 20 Lines • Show All 458 Lines • ▼ Show 20 Lines	/* -( Token Functions )---------------------------------------------------- */

/**		/**
* @task functions		* @task functions
*/		*/
public static function isFunctionToken($token) {		public static function isFunctionToken($token) {
// We're looking for a "(" so that a string like "members(q" is identified		// We're looking for a "(" so that a string like "members(q" is identified
// and parsed as a function call. This allows us to start generating		// and parsed as a function call. This allows us to start generating
// results immediately, before the user fully types out "members(quack)".		// results immediately, before the user fully types out "members(quack)".
		if ($token) {
return (strpos($token, '(') !== false);		return (strpos($token, '(') !== false);
		} else {
		return false;
		}
		valerio.bozzolanUnsubmitted Done Inline Actions ✅ I verified the above line Yes, we are aware that the `if($token)` skips the string `"0"` and it has sense here. This is valid since a function token must contain a bracket to be valid. valerio.bozzolan: ✅ I verified the above line Yes, we are aware that the `if($token)` skips the string `"0"` and…
}		}


/**		/**
* @task functions		* @task functions
*/		*/
protected function parseFunction($token, $allow_partial = false) {		protected function parseFunction($token, $allow_partial = false) {
$matches = null;		$matches = null;
▲ Show 20 Lines • Show All 166 Lines • Show Last 20 Lines