Page MenuHomePhorge
Differential D25229 Diff 737 src/applications/auth/storage/PhabricatorAuthChallenge.php

Changeset View

Standalone View

View Options

src/applications/auth/storage/PhabricatorAuthChallenge.php

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines public static function newHTTPParametersFromChallenges(array $challenges) {
); );
} }
public static function newChallengeResponsesFromRequest( public static function newChallengeResponsesFromRequest(
array $challenges, array $challenges,
AphrontRequest $request) { AphrontRequest $request) {
assert_instances_of($challenges, __CLASS__); assert_instances_of($challenges, __CLASS__);
$token_list = $request->getStr(self::HTTPKEY); $token_list = $request->getStr(self::HTTPKEY);
valerio.bozzolanUnsubmitted
Not Done
Inline Actions
assert_instances_of($challenges, __CLASS__);
- $token_list = $request->getStr(self::HTTPKEY);
+ $token_list = $request->getStr(self::HTTPKEY, '');
$token_list = explode(' ', $token_list);

Also here probably the minimal change is just the above one

valerio.bozzolan: Also here probably the minimal change is just the above one
if (phutil_nonempty_string($token_list)) {
$token_list = explode(' ', $token_list); $token_list = explode(' ', $token_list);
} else {
$token_list = [];
}
$token_map = array(); $token_map = array();
foreach ($token_list as $token_element) { foreach ($token_list as $token_element) {
$token_element = trim($token_element, ' '); $token_element = trim($token_element, ' ');
if (!strlen($token_element)) { if (!strlen($token_element)) {
continue; continue;
} }
▲ Show 20 Lines • Show All 204 Lines • Show Last 20 Lines
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0