Differential D25197 Diff 687 src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
| Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Lines | if ($application->isPrototype()) { | ||||
| $properties->addProperty( | $properties->addProperty( | ||||
| pht('Prototype'), | pht('Prototype'), | ||||
| pht( | pht( | ||||
| 'This application is a prototype. %s', | 'This application is a prototype. %s', | ||||
| $learn_more)); | $learn_more)); | ||||
| } | } | ||||
| $overview = $application->getOverview(); | $overview = $application->getOverview(); | ||||
| if (strlen($overview)) { | if (phutil_nonempty_string($overview)) { | ||||
valerio.bozzolan: ✅ I verified that the `$application->getOverview()` method only returns null or strings (raw… | |||||
| $overview = new PHUIRemarkupView($viewer, $overview); | $overview = new PHUIRemarkupView($viewer, $overview); | ||||
| $properties->addSectionHeader( | $properties->addSectionHeader( | ||||
| pht('Overview'), PHUIPropertyListView::ICON_SUMMARY); | pht('Overview'), PHUIPropertyListView::ICON_SUMMARY); | ||||
| $properties->addTextContent($overview); | $properties->addTextContent($overview); | ||||
| } | } | ||||
| return $properties; | return $properties; | ||||
| } | } | ||||
| ▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ I verified that the $application->getOverview() method only returns null or strings (raw remarkup).
The method phutil_nonempty_string() will report any alien type, and that is OK here.