Differential D25177 Diff 640 src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
Changeset View
Changeset View
Standalone View
Standalone View
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
| Show All 24 Lines | public function getApplicationTransactionRemarkupBlocks( | ||||
| return array( | return array( | ||||
| $xaction->getNewValue(), | $xaction->getNewValue(), | ||||
| ); | ); | ||||
| } | } | ||||
| public function renderPropertyViewValue(array $handles) { | public function renderPropertyViewValue(array $handles) { | ||||
| $value = $this->getFieldValue(); | $value = $this->getFieldValue(); | ||||
| if (!strlen($value)) { | if (!phutil_nonempty_string($value)) { | ||||
valerio.bozzolan: ✅ I logged `$value` with `phlog()` and I can confirm it just contains the exact string of the… | |||||
| return null; | return null; | ||||
| } | } | ||||
| // TODO: Once this stabilizes, it would be nice to let fields batch this. | // TODO: Once this stabilizes, it would be nice to let fields batch this. | ||||
| // For now, an extra query here and there on object detail pages isn't the | // For now, an extra query here and there on object detail pages isn't the | ||||
| // end of the world. | // end of the world. | ||||
| $viewer = $this->getViewer(); | $viewer = $this->getViewer(); | ||||
| ▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ I logged $value with phlog() and I can confirm it just contains the exact string of the description, or null.
The function phutil_nonempty_string() will report any alien value, and that is OK.