Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/editfield/PhabricatorTextEditField.php
Show All 12 Lines | final class PhabricatorTextEditField | ||||
public function getPlaceholder() { | public function getPlaceholder() { | ||||
return $this->placeholder; | return $this->placeholder; | ||||
} | } | ||||
protected function newControl() { | protected function newControl() { | ||||
$control = new AphrontFormTextControl(); | $control = new AphrontFormTextControl(); | ||||
$placeholder = $this->getPlaceholder(); | $placeholder = $this->getPlaceholder(); | ||||
if (strlen($placeholder)) { | if (phutil_nonempty_string($placeholder)) { | ||||
valerio.bozzolan: ✅ It seems the usages are just about null or strings. Alien values will be reported and this is… | |||||
$control->setPlaceholder($placeholder); | $control->setPlaceholder($placeholder); | ||||
} | } | ||||
return $control; | return $control; | ||||
} | } | ||||
protected function newConduitParameterType() { | protected function newConduitParameterType() { | ||||
return new ConduitStringParameterType(); | return new ConduitStringParameterType(); | ||||
} | } | ||||
protected function newBulkParameterType() { | protected function newBulkParameterType() { | ||||
return new BulkStringParameterType(); | return new BulkStringParameterType(); | ||||
} | } | ||||
} | } |
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ It seems the usages are just about null or strings. Alien values will be reported and this is OK.
Example usages: