Differential D25146 Diff 590 src/view/form/control/AphrontFormTokenizerControl.php

Changeset View

Standalone View

Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Lines	protected function renderInput() {
$datasource = $this->datasource;		$datasource = $this->datasource;
if (!$datasource) {		if (!$datasource) {
throw new Exception(		throw new Exception(
pht('You must set a datasource to use a TokenizerControl.'));		pht('You must set a datasource to use a TokenizerControl.'));
}		}
$datasource->setViewer($this->getUser());		$datasource->setViewer($this->getUser());

$placeholder = null;		$placeholder = null;
if (!strlen($this->placeholder)) {		if (!phutil_nonempty_string($this->placeholder)) {
		valerio.bozzolanUnsubmitted Done Inline Actions ✅ I was not able to test a value with `$this->placeholder` != null, but it seems to me that the intended usage is with string. The method `phutil_nonempty_string()` will report alien types, and this is OK. valerio.bozzolan: ✅ I was not able to test a value with `$this->placeholder` != null, but it seems to me that the…
$placeholder = $datasource->getPlaceholderText();		$placeholder = $datasource->getPlaceholderText();
}		}

$values = nonempty($this->getValue(), array());		$values = nonempty($this->getValue(), array());
$tokens = $datasource->renderTokens($values);		$tokens = $datasource->renderTokens($values);

foreach ($tokens as $token) {		foreach ($tokens as $token) {
$token->setInputName($this->getName());		$token->setInputName($this->getName());
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines