Differential D25160 Diff 582 src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

Changeset View

Standalone View

Show All 33 Lines	public function newSettingsPanelEditFormHeadContent(

if ($state->getIsSubmit()) {		if ($state->getIsSubmit()) {
return null;		return null;
}		}

$viewer = $this->getViewer();		$viewer = $this->getViewer();
$pattern = $viewer->getUserSetting(PhabricatorEditorSetting::SETTINGKEY);		$pattern = $viewer->getUserSetting(PhabricatorEditorSetting::SETTINGKEY);

if (!strlen($pattern)) {		if (!phutil_nonempty_string($pattern)) {
		valerio.bozzolanUnsubmitted Done Inline Actions ✅ I tested this locally with `phlog()` and it seems the valid input domain of `$pattern` is just string - with values like `"txmt://open/?url=file:///Users/alincoln/editor_links/%n/%f&line=%l"`, or a default to null. The `phutil_nonempty_string()` will report alien types, and that is OK. valerio.bozzolan: ✅ I tested this locally with `phlog()` and it seems the valid input domain of `$pattern` is…
return null;		return null;
}		}

$caught = null;		$caught = null;
try {		try {
id(new PhabricatorEditorURIEngine())		id(new PhabricatorEditorURIEngine())
->setPattern($pattern)		->setPattern($pattern)
->validatePattern();		->validatePattern();
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines