Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/editengine/PhabricatorEditEngine.php
| Show First 20 Lines • Show All 935 Lines • ▼ Show 20 Lines | final public function buildResponse() { | ||||
| if ($use_default) { | if ($use_default) { | ||||
| $config = $this->loadDefaultConfiguration(); | $config = $this->loadDefaultConfiguration(); | ||||
| if (!$config) { | if (!$config) { | ||||
| return new Aphront404Response(); | return new Aphront404Response(); | ||||
| } | } | ||||
| } else { | } else { | ||||
| $form_key = $request->getURIData('formKey'); | $form_key = $request->getURIData('formKey'); | ||||
| if (strlen($form_key)) { | if (phutil_nonempty_string($form_key)) { | ||||
valerio.bozzolan: ✅ I logged `$form_key` to check its values and its domain seems to be NULL or strings like… | |||||
| $config = $this->loadEditEngineConfigurationWithIdentifier($form_key); | $config = $this->loadEditEngineConfigurationWithIdentifier($form_key); | ||||
| if (!$config) { | if (!$config) { | ||||
| return new Aphront404Response(); | return new Aphront404Response(); | ||||
| } | } | ||||
| if ($id && !$config->getIsEdit()) { | if ($id && !$config->getIsEdit()) { | ||||
| return $this->buildNotEditFormRespose($object, $config); | return $this->buildNotEditFormRespose($object, $config); | ||||
| ▲ Show 20 Lines • Show All 1,801 Lines • Show Last 20 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ I logged $form_key to check its values and its domain seems to be NULL or strings like default. Alien values will be reported by phutil_nonempty_string() and this is OK.