Changeset View
Changeset View
Standalone View
Standalone View
src/applications/conduit/query/PhabricatorConduitSearchEngine.php
| Show All 33 Lines | public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) { | ||||
| $query = id(new PhabricatorConduitMethodQuery()); | $query = id(new PhabricatorConduitMethodQuery()); | ||||
| $query->withIsStable($saved->getParameter('isStable')); | $query->withIsStable($saved->getParameter('isStable')); | ||||
| $query->withIsUnstable($saved->getParameter('isUnstable')); | $query->withIsUnstable($saved->getParameter('isUnstable')); | ||||
| $query->withIsDeprecated($saved->getParameter('isDeprecated')); | $query->withIsDeprecated($saved->getParameter('isDeprecated')); | ||||
| $query->withIsInternal(false); | $query->withIsInternal(false); | ||||
| $contains = $saved->getParameter('nameContains'); | $contains = $saved->getParameter('nameContains'); | ||||
| if (strlen($contains)) { | if (phutil_nonempty_string($contains)) { | ||||
valerio.bozzolan: ✅ I logged the value of `$contains` in /conduit/query/ and its domain seems to be always NULL… | |||||
| $query->withNameContains($contains); | $query->withNameContains($contains); | ||||
| } | } | ||||
| return $query; | return $query; | ||||
| } | } | ||||
| public function buildSearchForm( | public function buildSearchForm( | ||||
| AphrontFormView $form, | AphrontFormView $form, | ||||
| ▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ I logged the value of $contains in /conduit/query/ and its domain seems to be always NULL or a string. Alien values will be reported by phutil_nonempty_string() and that is OK.