Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/editfield/PhabricatorTextEditField.php
| Show All 12 Lines | final class PhabricatorTextEditField | ||||
| public function getPlaceholder() { | public function getPlaceholder() { | ||||
| return $this->placeholder; | return $this->placeholder; | ||||
| } | } | ||||
| protected function newControl() { | protected function newControl() { | ||||
| $control = new AphrontFormTextControl(); | $control = new AphrontFormTextControl(); | ||||
| $placeholder = $this->getPlaceholder(); | $placeholder = $this->getPlaceholder(); | ||||
| if (strlen($placeholder)) { | if (phutil_nonempty_string($placeholder)) { | ||||
valerio.bozzolan: ✅ It seems the usages are just about null or strings. Alien values will be reported and this is… | |||||
| $control->setPlaceholder($placeholder); | $control->setPlaceholder($placeholder); | ||||
| } | } | ||||
| return $control; | return $control; | ||||
| } | } | ||||
| protected function newConduitParameterType() { | protected function newConduitParameterType() { | ||||
| return new ConduitStringParameterType(); | return new ConduitStringParameterType(); | ||||
| } | } | ||||
| protected function newBulkParameterType() { | protected function newBulkParameterType() { | ||||
| return new BulkStringParameterType(); | return new BulkStringParameterType(); | ||||
| } | } | ||||
| } | } | ||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ It seems the usages are just about null or strings. Alien values will be reported and this is OK.
Example usages:
./src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php: ->setPlaceholder(pht('rXabcdef, PHID-DIFF-1234, ...')) ./src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php: ->setPlaceholder(pht('rXYZ, R123, D456, ...')) ./src/applications/diffusion/controller/DiffusionRepositoryController.php: ->setPlaceholder(pht('Locate File'))); ./src/applications/auth/editor/PhabricatorAuthFactorProviderEditEngine.php: ->setPlaceholder($factor_name), ./src/applications/calendar/editor/PhabricatorCalendarImportEditEngine.php: ->setPlaceholder($object->getDisplayName()) ./src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/home/menuitem/PhabricatorHomeLauncherProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/people/menuitem/PhabricatorPeopleCommitsProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/people/menuitem/PhabricatorPeopleManageProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/people/menuitem/PhabricatorPeopleBadgesProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/people/menuitem/PhabricatorPeopleRevisionsProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/people/menuitem/PhabricatorPeopleDetailsProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/transactions/editfield/PhabricatorTextEditField.php: public function setPlaceholder($placeholder) { ./src/applications/transactions/editfield/PhabricatorTextEditField.php: $control->setPlaceholder($placeholder); ./src/applications/search/field/PhabricatorSearchDateField.php: ->setPlaceholder(pht('"2022-12-25" or "7 days ago"...')); ./src/applications/search/field/PhabricatorSearchStringListField.php: public function setPlaceholder($placeholder) { ./src/applications/search/field/PhabricatorSearchStringListField.php: $control->setPlaceholder($placeholder); ./src/applications/search/menuitem/PhabricatorManageProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/project/menuitem/PhabricatorProjectDetailsProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/project/menuitem/PhabricatorProjectSubprojectsProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/project/menuitem/PhabricatorProjectManageProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/project/menuitem/PhabricatorProjectMembersProfileMenuItem.php: ->setPlaceholder($this->getDefaultName()) ./src/applications/project/controller/trigger/PhabricatorProjectTriggerEditController.php: ->setPlaceholder($trigger->getDefaultName())); ./src/applications/config/custom/PhabricatorCustomLogoConfigType.php: ->setPlaceholder(PlatformSymbols::getPlatformServerName()) ./src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php: ->setPlaceholder($this->getPlaceholder()); ./src/view/form/control/AphrontFormTokenizerControl.php: public function setPlaceholder($placeholder) { ./src/view/form/control/AphrontFormTextControl.php: public function setPlaceholder($placeholder) { ./src/view/form/control/AphrontFormTypeaheadControl.php: public function setPlaceholder($placeholder)