Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/editfield/PhabricatorEditField.php
| Show First 20 Lines • Show All 412 Lines • ▼ Show 20 Lines | if ($control !== null) { | ||||
| ->setError(pht('Hidden')); | ->setError(pht('Hidden')); | ||||
| } else if ($this->getIsLocked()) { | } else if ($this->getIsLocked()) { | ||||
| $control | $control | ||||
| ->setError(pht('Locked')); | ->setError(pht('Locked')); | ||||
| } | } | ||||
| } | } | ||||
| $instructions = $this->getControlInstructions(); | $instructions = $this->getControlInstructions(); | ||||
| if (strlen($instructions)) { | if (phutil_nonempty_string($instructions)) { | ||||
valerio.bozzolan: ✅ I tested this locally with `phlog()` in various pages and it seems `$instructions` is always… | |||||
| $form->appendRemarkupInstructions($instructions); | $form->appendRemarkupInstructions($instructions); | ||||
| } | } | ||||
| $form->appendControl($control); | $form->appendControl($control); | ||||
| } | } | ||||
| return $this; | return $this; | ||||
| } | } | ||||
| ▲ Show 20 Lines • Show All 491 Lines • Show Last 20 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ I tested this locally with phlog() in various pages and it seems $instructions is always null or string like "Set Full Domain URI if you plan to serve this blog on another hosted domain" etc. - Any other alien value will be reported and this is OK.