Differential D25147 Diff 558 src/applications/files/controller/PhabricatorFileDataController.php

Changeset View

Standalone View

src/applications/files/controller/PhabricatorFileDataController.php

Show All 23 Lines	public function handleRequest(AphrontRequest $request) {
$alt_uri = new PhutilURI($alt);		$alt_uri = new PhutilURI($alt);
$alt_domain = $alt_uri->getDomain();		$alt_domain = $alt_uri->getDomain();
$req_domain = $request->getHost();		$req_domain = $request->getHost();
$main_domain = id(new PhutilURI($base_uri))->getDomain();		$main_domain = id(new PhutilURI($base_uri))->getDomain();

$request_kind = $request->getURIData('kind');		$request_kind = $request->getURIData('kind');
$is_download = ($request_kind === 'download');		$is_download = ($request_kind === 'download');

if (!strlen($alt) \|\| $main_domain == $alt_domain) {		if (!phutil_nonempty_string($alt) \|\| $main_domain == $alt_domain) {
		valerio.bozzolanUnsubmitted Done Inline Actions ✅ It seems `$alt_uri->getDomain()` is null as default and usages seems to just use `setDomain(string)`. The `phutil_nonempty_string()` will report alien values and this is OK. valerio.bozzolan: ✅ It seems `$alt_uri->getDomain()` is null as default and usages seems to just use `setDomain…
// No alternate domain.		// No alternate domain.
$should_redirect = false;		$should_redirect = false;
$is_alternate_domain = false;		$is_alternate_domain = false;
} else if ($req_domain != $alt_domain) {		} else if ($req_domain != $alt_domain) {
// Alternate domain, but this request is on the main domain.		// Alternate domain, but this request is on the main domain.
$should_redirect = true;		$should_redirect = true;
$is_alternate_domain = false;		$is_alternate_domain = false;
} else {		} else {
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines