Differential D25146 Diff 557 src/applications/search/controller/PhabricatorApplicationSearchController.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/search/controller/PhabricatorApplicationSearchController.php
| Show First 20 Lines • Show All 769 Lines • ▼ Show 20 Lines | private function buildNavigation() { | ||||
| return $nav; | return $nav; | ||||
| } | } | ||||
| private function renderNewUserView( | private function renderNewUserView( | ||||
| PhabricatorApplicationSearchEngine $engine, | PhabricatorApplicationSearchEngine $engine, | ||||
| $force_nux) { | $force_nux) { | ||||
| // Don't render NUX if the user has clicked away from the default page. | // Don't render NUX if the user has clicked away from the default page. | ||||
| if (strlen($this->getQueryKey())) { | if (phutil_nonempty_string($this->getQueryKey())) { | ||||
valerio.bozzolan: ✅ I used `phlog()` to test possible values of `$this->getQueryKey()` and it seems to me that it… | |||||
| return null; | return null; | ||||
| } | } | ||||
| // Don't put NUX in panels because it would be weird. | // Don't put NUX in panels because it would be weird. | ||||
| if ($engine->isPanelContext()) { | if ($engine->isPanelContext()) { | ||||
| return null; | return null; | ||||
| } | } | ||||
| ▲ Show 20 Lines • Show All 315 Lines • Show Last 20 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ I used phlog() to test possible values of $this->getQueryKey() and it seems to me that it always is null or a string like "all", "authored", "advanced", "I1bfBxtgm8kF", etc.
The phutil_nonempty_string() will report alien types, and this is OK.