Differential D25140 Diff 551 src/applications/project/menuitem/PhabricatorProjectMembersProfileMenuItem.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/project/menuitem/PhabricatorProjectMembersProfileMenuItem.php
| Show All 15 Lines | final class PhabricatorProjectMembersProfileMenuItem | ||||
| public function getMenuItemTypeIcon() { | public function getMenuItemTypeIcon() { | ||||
| return 'fa-users'; | return 'fa-users'; | ||||
| } | } | ||||
| public function getDisplayName( | public function getDisplayName( | ||||
| PhabricatorProfileMenuItemConfiguration $config) { | PhabricatorProfileMenuItemConfiguration $config) { | ||||
| $name = $config->getMenuItemProperty('name'); | $name = $config->getMenuItemProperty('name'); | ||||
| if (strlen($name)) { | if (phutil_nonempty_string($name)) { | ||||
valerio.bozzolan: ✅ The input domain seems correct to me, since it should be a string or `null` and alien values… | |||||
| return $name; | return $name; | ||||
| } | } | ||||
| return $this->getDefaultName(); | return $this->getDefaultName(); | ||||
| } | } | ||||
| public function buildEditEngineFields( | public function buildEditEngineFields( | ||||
| PhabricatorProfileMenuItemConfiguration $config) { | PhabricatorProfileMenuItemConfiguration $config) { | ||||
| Show All 31 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ The input domain seems correct to me, since it should be a string or null and alien values should be reported. Same as above.