Changeset View
Changeset View
Standalone View
Standalone View
src/view/control/AphrontTableView.php
Show First 20 Lines • Show All 129 Lines • ▼ Show 20 Lines | final class AphrontTableView extends AphrontView { | ||||
public function render() { | public function render() { | ||||
require_celerity_resource('aphront-table-view-css'); | require_celerity_resource('aphront-table-view-css'); | ||||
$table = array(); | $table = array(); | ||||
$col_classes = array(); | $col_classes = array(); | ||||
foreach ($this->columnClasses as $key => $class) { | foreach ($this->columnClasses as $key => $class) { | ||||
if (strlen($class)) { | if (phutil_nonempty_string($class)) { | ||||
valerio.bozzolan: ✅ I've manually checked 30+ files grepping for `setColumnClasses()` and I'm damn 99.999% sure… | |||||
$col_classes[] = $class; | $col_classes[] = $class; | ||||
} else { | } else { | ||||
$col_classes[] = null; | $col_classes[] = null; | ||||
} | } | ||||
} | } | ||||
$visibility = array_values($this->columnVisibility); | $visibility = array_values($this->columnVisibility); | ||||
$device_visibility = array_values($this->deviceVisibility); | $device_visibility = array_values($this->deviceVisibility); | ||||
▲ Show 20 Lines • Show All 268 Lines • Show Last 20 Lines |
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ I've manually checked 30+ files grepping for setColumnClasses() and I'm damn 99.999% sure that all the incoming values should be just NULL, string, or an empty string. Aliens values will be reported and that's OK.