Page MenuHomePhorge
Differential D25132 Diff 537 src/view/page/menu/PhabricatorMainMenuView.php

Changeset View

Standalone View

View Options

src/view/page/menu/PhabricatorMainMenuView.php

Show First 20 Lines • Show All 327 Lines • ▼ Show 20 Lines $logo_node = phutil_tag(
'span', 'span',
array( array(
'class' => 'phabricator-main-menu-project-logo', 'class' => 'phabricator-main-menu-project-logo',
'style' => implode(' ', $logo_style), 'style' => implode(' ', $logo_style),
)); ));
$wordmark_text = PhabricatorCustomLogoConfigType::getLogoWordmark(); $wordmark_text = PhabricatorCustomLogoConfigType::getLogoWordmark();
if (!strlen($wordmark_text)) { if (!phutil_nonempty_string($wordmark_text)) {
valerio.bozzolanUnsubmitted
Done
Inline Actions

✅ OK since the expected input domain is NULL (default) or a string. The phutil will throw for alien types, and it's OK.

Context:

./src/applications/config/custom/PhabricatorCustomLogoConfigType.php
public static function getLogoWordmark() {
  $logo = PhabricatorEnv::getEnvConfig('ui.logo');
  return idx($logo, 'wordmarkText');
}
valerio.bozzolan: ✅ OK since the expected input domain is **NULL** (default) or a **string**. The phutil will…
$wordmark_text = PlatformSymbols::getPlatformServerName(); $wordmark_text = PlatformSymbols::getPlatformServerName();
} }
$wordmark_node = phutil_tag( $wordmark_node = phutil_tag(
'span', 'span',
array( array(
'class' => 'phabricator-wordmark', 'class' => 'phabricator-wordmark',
), ),
▲ Show 20 Lines • Show All 392 Lines • Show Last 20 Lines
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0