Changeset View
Changeset View
Standalone View
Standalone View
src/applications/config/check/PhabricatorBinariesSetupCheck.php
| Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines | foreach ($vcses as $vcs) { | ||||||||
| continue; | continue; | ||||||||
| } | } | ||||||||
| $version = PhutilBinaryAnalyzer::getForBinary($binary) | $version = PhutilBinaryAnalyzer::getForBinary($binary) | ||||||||
| ->getBinaryVersion(); | ->getBinaryVersion(); | ||||||||
| switch ($vcs['versionControlSystem']) { | switch ($vcs['versionControlSystem']) { | ||||||||
| case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: | case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: | ||||||||
| $bad_versions = array(); | $bad_versions = array( | ||||||||
| // We need 2.5.0 to use "git cat-file -t -- <hash>:<file>" | |||||||||
| // https://we.phorge.it/T15179 | |||||||||
| '< 2.5.0' => pht( | |||||||||
| 'The minimum supported version of Git on the server is %s, '. | |||||||||
| 'which was released in %s. In older versions, the Git server '. | |||||||||
| 'may not be able to escape arguments with the "--" operator. '. | |||||||||
| 'Note: your users do not require a particular version of Git.', | |||||||||
aviveyUnsubmitted Done Inline Actions
avivey: | |||||||||
Done Inline ActionsBelieve me or not but it was exactly 80 characters, now 81 valerio.bozzolan: Believe me or not but it was exactly 80 characters, now 81 | |||||||||
Done Inline ActionsOK i just removed "that" valerio.bozzolan: OK i just removed "that" | |||||||||
| '2.5.0', | |||||||||
| '2015'), | |||||||||
| ); | |||||||||
| break; | break; | ||||||||
| case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: | case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: | ||||||||
| $bad_versions = array( | $bad_versions = array( | ||||||||
| // We need 1.5 for "--depth", see T7228. | // We need 1.5 for "--depth", see T7228. | ||||||||
| '< 1.5' => pht( | '< 1.5' => pht( | ||||||||
| 'The minimum supported version of Subversion is 1.5, which '. | 'The minimum supported version of Subversion is 1.5, which '. | ||||||||
| 'was released in 2008.'), | 'was released in 2008.'), | ||||||||
| '= 1.7.1' => pht( | '= 1.7.1' => pht( | ||||||||
| ▲ Show 20 Lines • Show All 141 Lines • Show Last 20 Lines | |||||||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0