Changeset View
Changeset View
Standalone View
Standalone View
webroot/rsrc/css/phui/phui-basic-nav-view.css
| Show All 17 Lines | |||||
| .phabricator-home.device .phui-navigation-shell .phabricator-nav-local { | .phabricator-home.device .phui-navigation-shell .phabricator-nav-local { | ||||
| display: table-cell; | display: table-cell; | ||||
| position: relative; | position: relative; | ||||
| vertical-align: top; | vertical-align: top; | ||||
| margin-top: 0; | margin-top: 0; | ||||
| overflow: hidden; | overflow: hidden; | ||||
| } | } | ||||
| .phabricator-home.device-phone .phabricator-nav-content { | .phabricator-home.device-phone .phui-navigation-shell .phabricator-nav-local { | ||||
speck: Oops one last question. It looks like this CSS selector matches the one immediately above. | |||||
Done Inline ActionsAh it looks like it’s not exactly the same after I expanded the context. Merging would likely cause nav to not display on desktop views. speck: Ah it looks like it’s not exactly the same after I expanded the context. Merging would likely… | |||||
Done Inline ActionsI think so And - thanks to what you focused - I now see this line probably was historically in this exact position since this section is dedicated to the local navigation bar, and so, it makes even more sense to touch that here, instead of touching contents as it was before - and that was probably a mistake. valerio.bozzolan: I think so
And - thanks to what you focused - I now see this line probably was historically in… | |||||
| display: none; | display: none; | ||||
| } | } | ||||
| .device-phone.phabricator-home .phui-basic-nav .phabricator-side-menu | .device-phone.phabricator-home .phui-basic-nav .phabricator-side-menu | ||||
| .phui-list-item-selected { | .phui-list-item-selected { | ||||
| background-color: transparent; | background-color: transparent; | ||||
| border-left-color: transparent; | border-left-color: transparent; | ||||
| font-weight: normal; | font-weight: normal; | ||||
| ▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
Oops one last question. It looks like this CSS selector matches the one immediately above. Should these be merged?