Differential D25119 Diff 473 support/startup/preamble-utils.php

Changeset View

Standalone View

Show All 15 Lines	if (!is_int($layers) \|\| ($layers < 1)) {
exit(1);		exit(1);
}		}

if (!isset($_SERVER['HTTP_X_FORWARDED_FOR'])) {		if (!isset($_SERVER['HTTP_X_FORWARDED_FOR'])) {
return;		return;
}		}

$forwarded_for = $_SERVER['HTTP_X_FORWARDED_FOR'];		$forwarded_for = $_SERVER['HTTP_X_FORWARDED_FOR'];
if (!phutil_nonempty_string($forwarded_for)) {		if (!is_string($forwarded_for) \|\| $forwarded_for === '') {
		valerio.bozzolanUnsubmitted Done Inline Actions This is a safe method to skip non-strings, NULL, or empty strings. Honestly we can also go for `if(!$forwarded_for)` since we are not interested in zero and it would be more readable. valerio.bozzolan: This is a safe method to skip non-strings, NULL, or empty strings. Honestly we can also go for…
return;		return;
}		}

$address = preamble_get_x_forwarded_for_address($forwarded_for, $layers);		$address = preamble_get_x_forwarded_for_address($forwarded_for, $layers);

$_SERVER['REMOTE_ADDR'] = $address;		$_SERVER['REMOTE_ADDR'] = $address;
}		}

▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines