Differential D25068 Diff 411 src/applications/project/controller/PhabricatorProjectBoardViewController.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/project/controller/PhabricatorProjectBoardViewController.php
| Show First 20 Lines • Show All 690 Lines • ▼ Show 20 Lines | private function buildColumnMenu( | ||||
| $specs = id(new ManiphestEditEngine()) | $specs = id(new ManiphestEditEngine()) | ||||
| ->setViewer($viewer) | ->setViewer($viewer) | ||||
| ->newCreateActionSpecifications(array()); | ->newCreateActionSpecifications(array()); | ||||
| foreach ($specs as $spec) { | foreach ($specs as $spec) { | ||||
| $column_items[] = id(new PhabricatorActionView()) | $column_items[] = id(new PhabricatorActionView()) | ||||
| ->setIcon($spec['icon']) | ->setIcon($spec['icon']) | ||||
| ->setName($spec['name']) | ->setName($spec['name']) | ||||
| ->setHref($spec['uri']) | ->setHref(id(new PhutilURI($spec['uri'])) | ||||
| ->replaceQueryParam('tags', $project->getPrimarySlug())) | |||||
valerio.bozzolan: Thank you again. I just suggest this change so to have better URLs and for the reasons… | |||||
| ->setDisabled($spec['disabled']) | ->setDisabled($spec['disabled']) | ||||
| ->addSigil('column-add-task') | ->addSigil('column-add-task') | ||||
| ->setMetadata( | ->setMetadata( | ||||
| array( | array( | ||||
| 'createURI' => $spec['uri'], | 'createURI' => $spec['uri'], | ||||
| 'columnPHID' => $column->getPHID(), | 'columnPHID' => $column->getPHID(), | ||||
| 'boardPHID' => $project->getPHID(), | 'boardPHID' => $project->getPHID(), | ||||
| 'projectPHID' => $default_phid, | 'projectPHID' => $default_phid, | ||||
| ▲ Show 20 Lines • Show All 333 Lines • Show Last 20 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
Thank you again. I just suggest this change so to have better URLs and for the reasons expressed in the comment.