Differential D25046 Diff 254 src/init/lib/PhutilBootloader.php

Changeset View

Standalone View

src/init/lib/PhutilBootloader.php

Show First 20 Lines • Show All 185 Lines • ▼ Show 20 Lines	public function getLibraryMapWithoutExtensions($name) {
// This just does all the checks to make sure the library is valid, then		// This just does all the checks to make sure the library is valid, then
// we throw away the result.		// we throw away the result.
$this->getLibraryMap($name);		$this->getLibraryMap($name);

return $this->libraryMaps[$name];		return $this->libraryMaps[$name];
}		}

public function getLibraryRoot($name) {		public function getLibraryRoot($name) {
		if ($name === 'phabricator') {
		// TODO warning
		Lint: TODO Comment Inline Actions This comment has a TODO. Lint: TODO Comment: This comment has a TODO.
		$name = 'phorge';
		}
		speckUnsubmitted Not Done Inline Actions It looks like there are ~61 instances of `phutil_get_library_root('phabricator')` in the phorge repo. Is the plan to eventually replace those? speck: It looks like there are ~61 instances of `phutil_get_library_root('phabricator')` in the phorge…
		aviveyAuthorUnsubmitted Done Inline Actions Probably, at some point. There's also the word `phabricator` in the Celerity/Javeline parts, and other infra stuff that is not exactly user-facing, but a bit public. avivey: Probably, at some point. There's also the word `phabricator` in the Celerity/Javeline parts…
if (empty($this->registeredLibraries[$name])) {		if (empty($this->registeredLibraries[$name])) {
throw new PhutilBootloaderException(		throw new PhutilBootloaderException(
"The phutil library '{$name}' has not been loaded!");		"The phutil library '{$name}' has not been loaded!");
}		}
return $this->registeredLibraries[$name];		return $this->registeredLibraries[$name];
}		}

public function getAllLibraries() {		public function getAllLibraries() {
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines