Differential D25040 Diff 97 src/applications/diffusion/protocol/DiffusionGitCommandEngine.php

Changeset View

Standalone View

src/applications/diffusion/protocol/DiffusionGitCommandEngine.php

	<?php			<?php

	final class DiffusionGitCommandEngine			final class DiffusionGitCommandEngine
	extends DiffusionCommandEngine {			extends DiffusionCommandEngine {

	protected function canBuildForRepository(			protected function canBuildForRepository(
	PhabricatorRepository $repository) {			PhabricatorRepository $repository) {
	return $repository->isGit();			return $repository->isGit();
	}			}

	protected function newFormattedCommand($pattern, array $argv) {			protected function newFormattedCommand($pattern, array $argv) {
	$pattern = "git {$pattern}";			$pattern = "git {$pattern}";
	return array($pattern, $argv);			return array($pattern, $argv);
	}			}

				protected function shouldAlwaysSudo() {

				// See T13673. In Git, always try to use "sudo" to execute commands as the
				// daemon user (if such a user is configured), because Git 2.35.2 and newer
				// (and some older versions of Git with backported security patches) refuse
				// to execute if the top level repository directory is not owned by the
				// current user.

				// Previously, we used "sudo" only when performing writes to the
				// repository directory.

				return true;
				}

	protected function newCustomEnvironment() {			protected function newCustomEnvironment() {
	$env = array();			$env = array();

	// NOTE: See T2965. Some time after Git 1.7.5.4, Git started fataling if			// NOTE: See T2965. Some time after Git 1.7.5.4, Git started fataling if
	// it can not read $HOME. For many users, $HOME points at /root (this			// it can not read $HOME. For many users, $HOME points at /root (this
	// seems to be a default result of Apache setup). Instead, explicitly			// seems to be a default result of Apache setup). Instead, explicitly
	// point $HOME at a readable, empty directory so that Git looks for the			// point $HOME at a readable, empty directory so that Git looks for the
	// config file it's after, fails to locate it, and moves on. This is			// config file it's after, fails to locate it, and moves on. This is
	Show All 27 Lines