Differential D25002 Diff 13 src/applications/base/PhabricatorApplication.php

Changeset View

Standalone View

src/applications/base/PhabricatorApplication.php

	<?php			<?php

	/**			/**
	* @task info Application Information			* @task info Application Information
	* @task ui UI Integration			* @task ui UI Integration
	* @task uri URI Routing			* @task uri URI Routing
	* @task mail Email integration			* @task mail Email integration
	* @task fact Fact Integration			* @task fact Fact Integration
	* @task meta Application Management			* @task meta Application Management
	*/			*/
	abstract class PhabricatorApplication			abstract class PhabricatorApplication
	extends PhabricatorLiskDAO			extends PhabricatorLiskDAO
	implements			implements
	PhabricatorPolicyInterface,			PhabricatorPolicyInterface,
	PhabricatorApplicationTransactionInterface {			PhabricatorApplicationTransactionInterface {

				const PROJECT_APPLICATION_NAME = 'Phabricator';
				speckAuthorUnsubmitted Done Inline Actions Before I get too much further on this I think this may actually need to be defined in Arcanist and not here. I’m sure Arcanist has loads of hardcoded “Phabricator” as well and it would be better to have it defined in a single place. speck: Before I get too much further on this I think this may actually need to be defined in Arcanist…
				deadalnixUnsubmitted Not Done Inline Actions Then maybe it is best to make this a function? This way where it points can be changed later on. deadalnix: Then maybe it is best to make this a function? This way where it points can be changed later on.
				speckAuthorUnsubmitted Done Inline Actions Yea I think turning this into a function will be better speck: Yea I think turning this into a function will be better

	const GROUP_CORE = 'core';			const GROUP_CORE = 'core';
	const GROUP_UTILITIES = 'util';			const GROUP_UTILITIES = 'util';
	const GROUP_ADMIN = 'admin';			const GROUP_ADMIN = 'admin';
	const GROUP_DEVELOPER = 'developer';			const GROUP_DEVELOPER = 'developer';

	final public static function getApplicationGroups() {			final public static function getApplicationGroups() {
	return array(			return array(
	self::GROUP_CORE => pht('Core Applications'),			self::GROUP_CORE => pht('Core Applications'),
	▲ Show 20 Lines • Show All 632 Lines • Show Last 20 Lines