Differential D25051 Diff 2350 src/applications/files/engineextension/PhabricatorFileAttachmentDestructionEngineExtension.php

Changeset View

Standalone View

<?php

final class PhabricatorFileAttachmentDestructionEngineExtension

extends PhabricatorDestructionEngineExtension {

aviveyUnsubmitted

Not Done

I might not have enough coffee yet, but what and when is triggering this extension?

avivey: I might not have enough coffee yet, but what and when is triggering this extension?

DylsssAuthorUnsubmitted

Done

Dylsss: https://we.phorge.it/source/phorge/browse/master/src/applications/system/engine/PhabricatorDest…

const EXTENSIONKEY = 'file.attachments';

public function getExtensionName() {

return pht('File Attachments');

}

public function destroyObject(

PhabricatorDestructionEngine $engine,

$object) {

$attachments = id(new PhabricatorFileAttachment())->loadAllWhere(

'objectPHID = %s',

$object->getPHID());

foreach ($attachments as $attachment) {

$attachment->delete();

}

valerio.bozzolanUnsubmitted

Not Done

foreach ($attachments as $attachment) {

- $attachment->delete();

+ $engine->destroyObject($attachment);

}

I'm unsure. It's just an idea thanks to speck (1)

valerio.bozzolan: I'm unsure. It's just an idea thanks to speck (1)

}