diff --git a/src/applications/auth/engine/PhabricatorAuthSessionEngine.php b/src/applications/auth/engine/PhabricatorAuthSessionEngine.php --- a/src/applications/auth/engine/PhabricatorAuthSessionEngine.php +++ b/src/applications/auth/engine/PhabricatorAuthSessionEngine.php @@ -109,7 +109,7 @@ * loading context. This prevents use of a Conduit sesssion as a Web * session, for example. * - * @param const $session_type The type of session to load. + * @param string $session_type Constant of the type of session to load. * @param string $session_token The session token. * @return PhabricatorUser|null * @task use @@ -250,7 +250,7 @@ * You can configure the maximum number of concurrent sessions for various * session types in the Phabricator configuration. * - * @param const $session_type Session type constant (see + * @param string $session_type Session type constant (see * @{class:PhabricatorAuthSession}). * @param phid|null $identity_phid Identity to establish a session for, * usually a user PHID. With `null`, generates an diff --git a/src/applications/differential/constants/DifferentialReviewerStatus.php b/src/applications/differential/constants/DifferentialReviewerStatus.php --- a/src/applications/differential/constants/DifferentialReviewerStatus.php +++ b/src/applications/differential/constants/DifferentialReviewerStatus.php @@ -19,8 +19,8 @@ * will attempt to update you to both "commented" and "accepted". We want * "accepted" to win, because it's the stronger of the two. * - * @param const $constant Reviewer status constant. - * @return int Relative strength (higher is stronger). + * @param string $constant Reviewer status constant. + * @return int Relative strength (higher is stronger). */ public static function getStatusStrength($constant) { $map = array( diff --git a/src/applications/harbormaster/constants/HarbormasterBuildStatus.php b/src/applications/harbormaster/constants/HarbormasterBuildStatus.php --- a/src/applications/harbormaster/constants/HarbormasterBuildStatus.php +++ b/src/applications/harbormaster/constants/HarbormasterBuildStatus.php @@ -96,7 +96,7 @@ /** * Get a human readable name for a build status constant. * - * @param const $status Build status constant. + * @param string $status Build status constant. * @return string Human-readable name. */ public static function getBuildStatusName($status) { diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php --- a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php +++ b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php @@ -88,7 +88,7 @@ * These tags are used to allow users to opt out of receiving certain types * of mail, like updates when a task's projects change. * - * @param list $tags + * @param list $tags Tag constants. * @return $this */ public function setMailTags(array $tags) { diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php --- a/src/applications/people/storage/PhabricatorUser.php +++ b/src/applications/people/storage/PhabricatorUser.php @@ -430,7 +430,7 @@ /** * Test if a given setting is set to a particular value. * - * @param const $key Setting key. + * @param string $key Setting key constant. * @param wild $value Value to compare. * @return bool True if the setting has the specified value. * @task settings diff --git a/src/applications/policy/interface/PhabricatorExtendedPolicyInterface.php b/src/applications/policy/interface/PhabricatorExtendedPolicyInterface.php --- a/src/applications/policy/interface/PhabricatorExtendedPolicyInterface.php +++ b/src/applications/policy/interface/PhabricatorExtendedPolicyInterface.php @@ -62,7 +62,7 @@ * // ... * ); * - * @param const $capability Capability being tested. + * @param string $capability Constant of the capability being tested. * @param PhabricatorUser $viewer Viewer whose capabilities are being tested. * @return list> List of extended policies. */ diff --git a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php --- a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php +++ b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php @@ -732,7 +732,8 @@ * * @param AphrontRequest $request Request to read user PHIDs from. * @param string $key Key to read in the request. - * @param list $allow_types (optional) Other permitted PHID types. + * @param list $allow_types (optional) Other permitted PHID type + * constants. * @return list List of user PHIDs and selector functions. * @task read */ @@ -807,8 +808,8 @@ * * @param AphrontRequest $request Request to read PHIDs from. * @param string $key Key to read in the request. - * @param list $allow_types (optional) List of permitted PHID - * types. + * @param list $allow_types (optional) List of permitted PHID + * type constants. * @return list List of object PHIDs. * * @task read diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php --- a/src/applications/transactions/editengine/PhabricatorEditEngine.php +++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php @@ -713,7 +713,7 @@ * to make Conduit a little easier to use. * * @param wild $identifier ID, PHID, or monogram. - * @param list $capabilities (optional) List of required capability + * @param list $capabilities (optional) List of required capability * constants, or omit for defaults. * @return object Corresponding editable object. * @task load @@ -793,7 +793,7 @@ * Load an object by ID. * * @param int $id Object ID. - * @param list $capabilities (optional) List of required capability + * @param list $capabilities (optional) List of required capability * constants, or omit for defaults. * @return object|null Object, or null if no such object exists. * @task load @@ -810,7 +810,7 @@ * Load an object by PHID. * * @param phid $phid Object PHID. - * @param list $capabilities (optional) List of required capability + * @param list $capabilities (optional) List of required capability * constants, or omit for defaults. * @return object|null Object, or null if no such object exists. * @task load @@ -827,7 +827,7 @@ * Load an object given a configured query. * * @param PhabricatorPolicyAwareQuery $query Configured query. - * @param list $capabilities (optional) List of required capability + * @param list $capabilities (optional) List of required capability * constants, or omit for defaults. * @return object|null Object, or null if no such object exists. * @task load diff --git a/src/infrastructure/contentsource/PhabricatorContentSource.php b/src/infrastructure/contentsource/PhabricatorContentSource.php --- a/src/infrastructure/contentsource/PhabricatorContentSource.php +++ b/src/infrastructure/contentsource/PhabricatorContentSource.php @@ -22,9 +22,9 @@ /** * Construct a new content source object. * - * @param const $source The source type constant to build a source for. - * @param array $params (optional) Source parameters. - * @param bool $force (optional) True to suppress errors and force + * @param string $source The source type constant to build a source for. + * @param array $params (optional) Source parameters. + * @param bool $force (optional) True to suppress errors and force * construction of a source even if the source type is not valid. * @return PhabricatorContentSource New source object. */ diff --git a/src/infrastructure/customfield/field/PhabricatorCustomField.php b/src/infrastructure/customfield/field/PhabricatorCustomField.php --- a/src/infrastructure/customfield/field/PhabricatorCustomField.php +++ b/src/infrastructure/customfield/field/PhabricatorCustomField.php @@ -1570,8 +1570,9 @@ /** * Get the Herald value type for the given condition. * - * @param const $condition Herald condition constant. - * @return const|null Herald value type, or null to use the default. + * @param string $condition Herald condition constant. + * @return string|null Herald value type constant, or null to use the + * default. * @task herald */ public function getHeraldFieldValueType($condition) { diff --git a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php --- a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php +++ b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php @@ -59,7 +59,7 @@ * triggers which have been scheduled to execute. You should not use this * ordering when querying for specific triggers, e.g. by ID or PHID. * - * @param const $order Result order. + * @param string $order Result order constant. * @return $this */ public function setOrder($order) { diff --git a/src/infrastructure/edges/editor/PhabricatorEdgeEditor.php b/src/infrastructure/edges/editor/PhabricatorEdgeEditor.php --- a/src/infrastructure/edges/editor/PhabricatorEdgeEditor.php +++ b/src/infrastructure/edges/editor/PhabricatorEdgeEditor.php @@ -46,7 +46,7 @@ * provided, `data` will be written. * * @param phid $src Source object PHID. - * @param const $type Edge type constant. + * @param string $type Edge type constant. * @param phid $dst Destination object PHID. * @param map $options (optional) Options map (see documentation). * @return $this @@ -68,7 +68,7 @@ * a remove plus an add is to overwrite. * * @param phid $src Source object PHID. - * @param const $type Edge type constant. + * @param string $type Edge type constant. * @param phid $dst Destination object PHID. * @return $this * diff --git a/src/infrastructure/edges/query/PhabricatorEdgeQuery.php b/src/infrastructure/edges/query/PhabricatorEdgeQuery.php --- a/src/infrastructure/edges/query/PhabricatorEdgeQuery.php +++ b/src/infrastructure/edges/query/PhabricatorEdgeQuery.php @@ -88,7 +88,7 @@ /** * Configure the order edge results are returned in. * - * @param const $order Order constant. + * @param string $order Order constant. * @return $this * * @task config @@ -122,7 +122,7 @@ * use case. * * @param phid $src_phid Source PHID. - * @param const $edge_type Edge type. + * @param string $edge_type Edge type constant. * @return list List of destination PHIDs. */ public static function loadDestinationPHIDs($src_phid, $edge_type) { @@ -140,7 +140,7 @@ * and immediately executes a full query. * * @param phid $src_phid Source PHID. - * @param const $edge_type Edge type. + * @param string $edge_type Edge type constant. * @param phid $dest_phid Destination PHID. * @return wild Edge annotation (or null). */ diff --git a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php --- a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php +++ b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php @@ -2587,8 +2587,8 @@ * Convenience method for specifying edge logic constraints with a list of * PHIDs. * - * @param const $edge_type Edge constant. - * @param const $operator Constraint operator. + * @param string $edge_type Edge constant. + * @param string $operator Constraint operator. * @param list $phids List of PHIDs. * @return $this * @task edgelogic diff --git a/src/infrastructure/storage/lisk/LiskDAO.php b/src/infrastructure/storage/lisk/LiskDAO.php --- a/src/infrastructure/storage/lisk/LiskDAO.php +++ b/src/infrastructure/storage/lisk/LiskDAO.php @@ -402,7 +402,7 @@ /** * Determine the setting of a configuration option for this class of objects. * - * @param const $option_name Option name, one of the CONFIG_* constants. + * @param string $option_name Option name, one of the CONFIG_* constants. * @return mixed Option value, if configured (null if unavailable). * * @task config @@ -1042,7 +1042,7 @@ /** * Internal implementation of INSERT and REPLACE. * - * @param const $mode Either "INSERT" or "REPLACE", to force the desired + * @param string $mode Either "INSERT" or "REPLACE", to force the desired * mode. * @return $this *