diff --git a/src/configuration/ArcanistSettings.php b/src/configuration/ArcanistSettings.php --- a/src/configuration/ArcanistSettings.php +++ b/src/configuration/ArcanistSettings.php @@ -236,7 +236,6 @@ throw new Exception( pht( 'Use "arc alias" to configure aliases, not "arc set-config".')); - break; } diff --git a/src/parser/PhutilTypeSpec.php b/src/parser/PhutilTypeSpec.php --- a/src/parser/PhutilTypeSpec.php +++ b/src/parser/PhutilTypeSpec.php @@ -336,7 +336,6 @@ $obj->subtypes[] = $r; return $obj; } - break; case 'map_type': $obj = new PhutilTypeSpec(); $obj->type = 'map'; @@ -355,7 +354,6 @@ } else { return $tokens[0]; } - break; case 'maybe_comment': if ($production == 'yes') { $tokens[0]->comment = $tokens[1]; diff --git a/src/parser/__tests__/ArcanistDiffParserTestCase.php b/src/parser/__tests__/ArcanistDiffParserTestCase.php --- a/src/parser/__tests__/ArcanistDiffParserTestCase.php +++ b/src/parser/__tests__/ArcanistDiffParserTestCase.php @@ -610,7 +610,6 @@ break; default: throw new Exception(pht('No test block for diff file %s.', $diff_file)); - break; } } diff --git a/src/parser/xhpast/api/XHPASTNode.php b/src/parser/xhpast/api/XHPASTNode.php --- a/src/parser/xhpast/api/XHPASTNode.php +++ b/src/parser/xhpast/api/XHPASTNode.php @@ -31,7 +31,6 @@ switch ($this->getTypeName()) { case 'n_STATEMENT': return $this->getChildByIndex(0)->evalStatic(); - break; case 'n_STRING_SCALAR': return phutil_string_cast($this->getStringLiteralValue()); case 'n_HEREDOC': @@ -61,22 +60,18 @@ default: throw new Exception(pht('Unrecognized symbol name.')); } - break; case 'n_UNARY_PREFIX_EXPRESSION': $operator = $this->getChildOfType(0, 'n_OPERATOR'); $operand = $this->getChildByIndex(1); switch ($operator->getSemanticString()) { case '-': return -$operand->evalStatic(); - break; case '+': return $operand->evalStatic(); - break; default: throw new Exception( pht('Unexpected operator in static expression.')); } - break; case 'n_ARRAY_LITERAL': $result = array(); $values = $this->getChildOfType(0, 'n_ARRAY_VALUE_LIST'); diff --git a/src/xsprintf/tsprintf.php b/src/xsprintf/tsprintf.php --- a/src/xsprintf/tsprintf.php +++ b/src/xsprintf/tsprintf.php @@ -68,7 +68,6 @@ 'Unsupported escape sequence "%s" found in pattern: %s', $type, $pattern)); - break; } $pattern[$pos] = $type;