diff --git a/resources/celerity/map.php b/resources/celerity/map.php --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -396,7 +396,7 @@ 'rsrc/js/application/diffusion/behavior-pull-lastmodified.js' => 'c715c123', 'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => '6a85bc5a', 'rsrc/js/application/drydock/drydock-live-operation-status.js' => '47a0728b', - 'rsrc/js/application/fact/Chart.js' => '0076c427', + 'rsrc/js/application/fact/Chart.js' => '351abd1c', 'rsrc/js/application/fact/ChartCurtainView.js' => '86954222', 'rsrc/js/application/fact/ChartFunctionLabel.js' => '81de1dab', 'rsrc/js/application/files/behavior-document-engine.js' => '243d6c22', @@ -702,7 +702,7 @@ 'javelin-behavior-user-menu' => '60cd9241', 'javelin-behavior-view-placeholder' => 'a9942052', 'javelin-behavior-workflow' => '9623adc1', - 'javelin-chart' => '0076c427', + 'javelin-chart' => '351abd1c', 'javelin-chart-curtain-view' => '86954222', 'javelin-chart-function-label' => '81de1dab', 'javelin-color' => '78f811c9', @@ -918,12 +918,6 @@ 'unhandled-exception-css' => '9ecfc00d', ), 'requires' => array( - '0076c427' => array( - 'phui-chart-css', - 'd3', - 'javelin-chart-curtain-view', - 'javelin-chart-function-label', - ), '0116d3e8' => array( 'javelin-behavior', 'javelin-dom', @@ -1239,6 +1233,12 @@ 'aphront-typeahead-control-css', 'phui-tag-view-css', ), + '351abd1c' => array( + 'phui-chart-css', + 'd3', + 'javelin-chart-curtain-view', + 'javelin-chart-function-label', + ), '3829a3cf' => array( 'javelin-behavior', 'javelin-uri', diff --git a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php --- a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php +++ b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php @@ -143,6 +143,7 @@ ->setDescription(pht('Search for tasks closed by certain users.')), id(new PhabricatorSearchIntField()) ->setLabel(pht('Page Size')) + ->setDefaultValue(100) // default limit defined in parent class ->setKey('limit'), ); } diff --git a/src/applications/search/field/PhabricatorSearchField.php b/src/applications/search/field/PhabricatorSearchField.php --- a/src/applications/search/field/PhabricatorSearchField.php +++ b/src/applications/search/field/PhabricatorSearchField.php @@ -13,6 +13,7 @@ private $conduitKey; private $viewer; private $value; + private $defaultValue; private $label; private $aliases = array(); private $errors = array(); @@ -283,7 +284,21 @@ } protected function getDefaultValue() { - return null; + return $this->defaultValue; + } + + /** + * Set a default field value + * + * Set a default value for a search field. + * Overrides a potential field placeholder value. + * + * @param wild Default value to be displayed in the SearchEngine + * @return this + */ + public function setDefaultValue($default_value) { + $this->defaultValue = $default_value; + return $this; } public function getValueForQuery($value) { diff --git a/src/applications/search/field/PhabricatorSearchIntField.php b/src/applications/search/field/PhabricatorSearchIntField.php --- a/src/applications/search/field/PhabricatorSearchIntField.php +++ b/src/applications/search/field/PhabricatorSearchIntField.php @@ -3,10 +3,6 @@ final class PhabricatorSearchIntField extends PhabricatorSearchField { - protected function getDefaultValue() { - return null; - } - protected function getValueFromRequest(AphrontRequest $request, $key) { return $request->getInt($key); }