Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating new Diffusion repository
ClosedPublic
Actions

Authored by aklapper on Apr 30 2023, 08:38.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15301: PHP 8.1 "strlen(null)" exception blocks loading icons when creating new Diffusion repository

Commits

rP5a76e8d26232: Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15301

Test Plan

Applied this change (on top of D25150) and icons rendered in web browser.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Apr 30 2023, 08:38

Owners added a reviewer: O1: Blessed Committers.Apr 30 2023, 08:38

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 30 2023, 08:38

aklapper requested review of this revision.Apr 30 2023, 08:38

Harbormaster completed remote builds in B297: Diff 563.Apr 30 2023, 08:38

valerio.bozzolan mentioned this in D25161: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public key settings dialog.Apr 30 2023, 22:52

aklapper mentioned this in rPe3ad37f79259: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public….Apr 30 2023, 23:08

valerio.bozzolan mentioned this in D25152: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Maniphest task creation page.May 1 2023, 08:16

valerio.bozzolan mentioned this in D25162: Fix PHP 8.1 "strlen(null)" exception which blocks rendering list of Active/All projects.May 1 2023, 08:21

valerio.bozzolan mentioned this in D25164: Fix PHP 8.1 "rawurlencode(null)" exception which blocks rendering a project page.May 1 2023, 13:36

aklapper mentioned this in rP313d3b7bf2ea: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Maniphest task….May 1 2023, 13:52

aklapper mentioned this in rP6e8852837004: Fix PHP 8.1 "strlen(null)" exception which blocks rendering list of Active/All….May 1 2023, 13:55

Thanks for this fix

Tested locally with / without HTTP Range playing an audio file.

sgtm

src/applications/files/controller/PhabricatorFileDataController.php
72	✅ The HTTP range assumes string values like `"bytes=0-"` etc. and null but not other things. The `phutil_nonempty_string()` will report alien values and that is OK.