Differential D25612

Use more css and phorge standard elements for application view
Needs ReviewPublic
Actions

Authored by bekay on Wed, May 1, 16:10.

Tags

Referenced Files

	Unknown Object (File)
	Fri, May 10, 08:11

	Unknown Object (File)
	Fri, May 10, 06:28

	Unknown Object (File)
	Fri, May 10, 04:22

	Unknown Object (File)
	Tue, May 7, 09:56

	Unknown Object (File)
	Sun, May 5, 23:33

	Unknown Object (File)
	Sun, May 5, 23:32

	Unknown Object (File)
	Sun, May 5, 23:32

	Unknown Object (File)
	Sun, May 5, 05:26

View All 18 Files

Subscribers

valerio.bozzolan

Details

Reviewers

mturdus
valerio.bozzolan

Summary

This diff streamlines the application view. This includes:

using the newPage method of the PhabricatorController
using the application crumb standard class for rendering of crumbs
using 📊 as application glyph
using css and flex for sizing of the drawio app iframe (circumvents magic css numbers)
implementing some phorge coding standards

Test Plan

Creating and editing diagrams (and older versions) look at the new breadcrumbs. Is everything looking and working as expected?

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 1215
Build 1215: arc lint + arc unit

Event Timeline

bekay created this revision.Wed, May 1, 16:10

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptWed, May 1, 16:10

bekay requested review of this revision.Wed, May 1, 16:10

Harbormaster completed remote builds in B1212: Diff 1919.Wed, May 1, 16:10

bekay edited the test plan for this revision. (Show Details)Wed, May 1, 16:12

Fixes regression from missing html element

Harbormaster completed remote builds in B1215: Diff 1926.Thu, May 2, 13:31

bekay added a project: Diagrams (Extension).Thu, May 2, 13:33

bekay edited subscribers, added: mturdus, valerio.bozzolan; removed: tobiaswiese, Matthew, Cigaryno.

bekay mentioned this in T15806: Use drawio viewer for rendering of diagrams.Thu, May 2, 13:40

Revision Contents
Changeset List

Path

Size

rsrc/

behavior-diagram-extension.js

24 lines

diagram-extension.css

35 lines

src/

application/

DiagramApplication.php

2 lines

celerity/

controller/

DiagramController.php

179 lines

Diff 1926

rsrc/behavior-diagram-extension.js

Loading...

rsrc/diagram-extension.css

Loading...

src/application/DiagramApplication.php

Loading...

src/celerity/map.php

Loading...

src/controller/DiagramController.php

Loading...